• thingsiplay@lemmy.ml
    link
    fedilink
    arrow-up
    8
    arrow-down
    1
    ·
    1 day ago

    In my experience this option is too risky. Making simple changes to the script without scientifically proofing and testing it works under all cases becomes impossible (depending on how complex the script and task itself is). It has a bit of the energy of “well you have to make no errors in C, then you can write good code and it never fails”.

    This option is good if the script MUST fail under any circumstances, if any error return of a program occurs. Which is usually not the case for most scripts. It’s also useful in testing when debugging or when developing. Also useful if you purposefully enable and disable the option on the fly for sensitive segments of the script. I do not like this option as a default.

    • MonkderVierte@lemmy.zip
      link
      fedilink
      arrow-up
      1
      ·
      edit-2
      13 hours ago

      This option is good if the script MUST fail under any circumstances

      I mean, that or file mangling, because you didn’t catch a error of some unplanned usecase.

    • Ephera@lemmy.ml
      link
      fedilink
      English
      arrow-up
      10
      ·
      1 day ago

      I don’t have the Bash experience to argue against that, but from a general programming experience, I want things to crash as loudly as possible when anything unexpected happens. Otherwise, you might never spot it failing.

      Well, and nevermind that it could genuinely break things, if an intermediate step fails, but it continues running.

      • thingsiplay@lemmy.ml
        link
        fedilink
        arrow-up
        6
        ·
        edit-2
        1 day ago

        Bash and the commandline are designed to work after an error. I don’t want it to fail after an error. It depends on the error though, and how critical it is. And this option makes no distinction. There are lot of commands where a fail is part of normal execution. As I said before, this option can be helpful when developing, but I do not want it in production. Often “silent” fails are a good thing (but as said, it depends on the type). The entire language is designed to sometimes fail and keep working as intended.

        You really can’t compare Bash to a normal programming language, because the language is contained and developed in itself. While Bash relies on random and unrelated applications. That’s why I do not like comparisons like that.

        Edit: I do do not want to exit the script on random error codes, but maybe handle the error. With that option in place, I have to make sure an error never happens. Which is not what I want.

        • Eager Eagle@lemmy.world
          link
          fedilink
          English
          arrow-up
          6
          ·
          edit-2
          24 hours ago

          Often “silent” fails are a good thing

          Silent fails have caused me to waste many hours of my time trying to figure out what the fuck was happening with a simple script. I’ve been using -e on nearly all bash code I’ve written for years - with the exception of sourced ones - and wouldn’t go back.

          If an unhandled error happened, I want my program to crash so I can evaluate whether I need to ignore it, or actually handle it.

        • Gobbel2000@programming.dev
          link
          fedilink
          arrow-up
          5
          ·
          23 hours ago

          But you can just as well make an exception to allow errors when -e is enabled with something like command || true, or even some warning message.

          I feel like, while it does occur, allowing errors like this is more unusual than stopping the script in an error, so it’s good to explicitly mark this case, therefore -e is still a reasonable default in most cases.

    • Feyd@programming.dev
      link
      fedilink
      arrow-up
      4
      ·
      1 day ago

      Ehhh I don’t think I’ve used bash outside of random stuff on my machine in years except in CI pipelines and wanting them to stop and fail the pipeline the second anything goes wrong is exactly what I want.

      • thingsiplay@lemmy.ml
        link
        fedilink
        arrow-up
        2
        ·
        1 day ago

        I do not want to think about every possible error that can happen. I do not want to study every program I call to look for any possible errors. Only errors that are important to my task.

        As I said, there are reasons to use this option when the script MUST fail on error.And its helpful for creating the script. I just don’t like generalizations to always enable this option.