In the last two years, code review has gotten much more important. Code is now easy to generate using LLMs, but it’s still just as hard to review. Many software…
Good, I just partially disagree with the 5-6 comments per PR. The number of comments is usually proportional to the number of changes. 10 comments in a 300-line PR seems excessive. 20 comments for 5k lines doesn’t.
Sure I can just shrug it and say I’m not reviewing a 10k line PR until it’s split, but that’s not very helpful either. So I just leave more comments and if they think it’s too much, I’d encourage them to open a smaller PR next time.
Good, I just partially disagree with the 5-6 comments per PR. The number of comments is usually proportional to the number of changes. 10 comments in a 300-line PR seems excessive. 20 comments for 5k lines doesn’t.
Sure I can just shrug it and say I’m not reviewing a 10k line PR until it’s split, but that’s not very helpful either. So I just leave more comments and if they think it’s too much, I’d encourage them to open a smaller PR next time.
Is it? I feel there’s some threshold where a big enough change sails through unimpeded if the requester is sufficiently liked.